Skip to content

fix: release concurrency token exhaustion no longer happens on batchTriggerAndWait #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: release concurrency token exhaustion no longer happens on batchTriggerAndWait #1937

merged 1 commit into from
Apr 17, 2025

Conversation

@ericallam
Copy link
Member

@ericallam ericallam commented Apr 17, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Introduced a new batch-triggering task that starts and waits for multiple short-duration child tasks.
  • Bug Fixes
    • Improved the timing and reliability of concurrency release when runs are suspended and resumed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 17, 2025 •
edited
Loading

Walkthrough

The changes update the concurrency release logic in the WaitpointSystem by moving the release action to occur immediately after a run is suspended by a waitpoint, rather than conditionally later. Additionally, a new batch-triggering mechanism is introduced in the trigger module, adding two tasks: one that triggers and waits for a batch of child tasks, and a child task that simply waits for a specified duration. No changes are made to exported method signatures in the system logic.

Changes

File(s) Change Summary
internal-packages/run-engine/src/engine/systems/waitpointSystem.ts Refactored concurrency release logic to occur immediately after suspending a run due to waitpoints.
references/hello-world/src/trigger/release-concurrency.ts Added batchTriggerAndWaitReleaseConcurrency task and supporting child task for batch-triggering with waits.

Sequence Diagram(s)

sequenceDiagram
    participant ParentTask as batchTriggerAndWaitReleaseConcurrency
    participant ChildTask as batchTriggerAndWaitChildTask
    loop 3 times
        ParentTask->>ChildTask: Trigger with waitSeconds=1
        ChildTask-->>ParentTask: Complete after 1s
    end
    ParentTask-->>ParentTask: Finish after all children complete
Loading

Possibly related PRs

Poem

In the warren where tasks hop and run,
Concurrency released, the waitpoint's done.
New batchy bunnies, three in a row,
Wait for a second, then off they go!
With logic refined and triggers anew,
The code leaps forward—hippity-hoo!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9aaec9 and ef902bd.

📒 Files selected for processing (2)
  • internal-packages/run-engine/src/engine/systems/waitpointSystem.ts (2 hunks)
  • references/hello-world/src/trigger/release-concurrency.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • internal-packages/run-engine/src/engine/systems/waitpointSystem.ts
  • references/hello-world/src/trigger/release-concurrency.ts
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: ef902bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken matt-aitken merged commit 4b42f77 into main Apr 17, 2025
12 checks passed
@matt-aitken matt-aitken deleted the ea-branch-47 branch April 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matt-aitken matt-aitken matt-aitken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericallam @matt-aitken